From b4d19082574e71a8ef60093ac68707c7f66d6acf Mon Sep 17 00:00:00 2001 From: Tim Fischbach Date: Thu, 1 Aug 2024 10:01:45 +0200 Subject: [PATCH] Prevent invisible hovering toolbar from taking focus Broke moving between editable texts using tab inside hotspots tooltip. REDMINE-20673 --- .../src/frontend/inlineEditing/EditableText/HoveringToolbar.js | 2 +- .../src/frontend/inlineEditing/EditableText/index.module.css | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/HoveringToolbar.js b/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/HoveringToolbar.js index b0feac74a..d26e49d91 100644 --- a/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/HoveringToolbar.js +++ b/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/HoveringToolbar.js @@ -43,7 +43,7 @@ export function HoveringToolbar({position}) { const rect = domRange.getBoundingClientRect() const outerRect = outerRef.current.getBoundingClientRect() - el.style.opacity = 1; + el.style.visibility = 'visible'; el.style.left = `${rect.left - outerRect.left}px`; if (position === 'above') { diff --git a/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/index.module.css b/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/index.module.css index 681ffc95e..fb7ae99c5 100644 --- a/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/index.module.css +++ b/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/index.module.css @@ -32,7 +32,7 @@ z-index: 2; top: -10000px; left: -10000px; - opacity: 0; + visibility: hidden; white-space: nowrap; }