Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Reference lookups aren't logging in database #723

Closed
geekygirlsarah opened this issue May 22, 2024 · 5 comments · Fixed by #724
Closed

Bug: Reference lookups aren't logging in database #723

geekygirlsarah opened this issue May 22, 2024 · 5 comments · Fixed by #724
Assignees
Labels
Experience: Backend good first issue A good issue for anyone new to open source to work on help wanted We'd love to have help working on this issue Priority: High Something to fix sooner than later python Pull requests that update Python code Type: Bug

Comments

@geekygirlsarah
Copy link
Member

geekygirlsarah commented May 22, 2024

Expected Behavior

Any reference page lookup should be storing what was looked up in the web_lookupdata table in the database

Actual Behavior

No lookup data is saving

Steps to Reproduce the Problem

  1. Lookup something (like Python version 3 functions)
  2. Look inside the SQLite (locally) or Postgres (if you set it up) to see the row isn't in there

Additional Info

Appears one hasn't been stored since Feb 2023. Maybe a migration could be added to catch this back up.

@geekygirlsarah geekygirlsarah added Type: Bug help wanted We'd love to have help working on this issue good first issue A good issue for anyone new to open source to work on Experience: Backend Priority: High Something to fix sooner than later python Pull requests that update Python code labels May 22, 2024
@Frederic-Chopin
Copy link
Contributor

Hi Sarah, is it okay if I work on this? I just created a PR that resolves this issue:
#724

I modified the concepts function in views.py to ensure that store_lookup_info is always called, even when there is only one language, which is the case for the reference lookup. I defaulted the second language to an empty string when there is only one language. I also tested locally and it works now, and web_lookupdata stores reference lookup correctly. If there is any question please let me know!

Copy link

github-actions bot commented Jun 6, 2024

This issue has been inactive for 336 hours (14.00 days) and will be unassigned after 72 more hours (3.00 days). If you have questions, please leave a comment, message @codethesaurus or @geekygirlsarah on Twitter, or email [email protected].If you are still working on this issue, that's fine. Please comment here to tell the bot to give you more time.

@geekygirlsarah
Copy link
Member Author

Commenting to keep open for @Frederic-Chopin to finish some unit tests

Copy link

This issue has been inactive for 348 hours (14.50 days) and will be unassigned after 60 more hours (2.50 days). If you have questions, please leave a comment, message @codethesaurus or @geekygirlsarah on Twitter, or email [email protected].If you are still working on this issue, that's fine. Please comment here to tell the bot to give you more time.

Copy link

This issue has been inactive for 420 hours (17.50 days) and is past the limit of 408 hours (17.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you for your interest in contributing to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experience: Backend good first issue A good issue for anyone new to open source to work on help wanted We'd love to have help working on this issue Priority: High Something to fix sooner than later python Pull requests that update Python code Type: Bug
Projects
Development

Successfully merging a pull request may close this issue.

2 participants