Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix unit test(s) to check HTTP status codes for invalid lookups #691

Closed
geekygirlsarah opened this issue Oct 26, 2023 · 5 comments · Fixed by #757
Closed

Add/fix unit test(s) to check HTTP status codes for invalid lookups #691

geekygirlsarah opened this issue Oct 26, 2023 · 5 comments · Fixed by #757
Assignees
Labels
Experience: Backend good first issue A good issue for anyone new to open source to work on hacktoberfest Good issue for someone to work on for Hacktoberfest help wanted We'd love to have help working on this issue Type: Maintenance

Comments

@geekygirlsarah
Copy link
Member

Description

Bug #690 resulted from a invalid language_name / friendly_language_name mixup that would result in 500 server errors. The unit test that seem to check for invalid language/structures didn't catch this.

This issue should add new unit test(s) or fix the existing unit test(s) to make this more robust.

Requirements

  • Unit tests that check behind the scenes if invalid languages are looked up should be added/fixed
  • Unit tests that check HTTP status codes (404, 500, others if needed) should be added/fixed for invalid lookups
  • Probably should also add/fix unit tests for other scenarios too (other pages don't exist, malformed URLs, etc.)

Additional Notes

This need to be tested locally to ensure they work:

  • python manage.py test should run all unit tests
  • python manage.py validatelanginfofiles should run tests on the language files
  • python manage.py validatemetainfofile should run tests on the meta info file

While they'll be run when a pull request is made, making sure they run and pass locally first will speed things up.

@geekygirlsarah geekygirlsarah added help wanted We'd love to have help working on this issue good first issue A good issue for anyone new to open source to work on hacktoberfest Good issue for someone to work on for Hacktoberfest Experience: Backend Type: Maintenance labels Oct 26, 2023
@sharktankful
Copy link

Hi I would love to work on this issue :)

@geekygirlsarah
Copy link
Member Author

Hey @sharktankful, I missed your comment somehow. Feel free to take it!

@geekygirlsarah
Copy link
Member Author

And let me know if you need any help.

Copy link

This issue has been inactive for 345 hours (14.38 days) and will be unassigned after 63 more hours (2.63 days). If you have questions, please leave a comment, message @codethesaurus or @geekygirlsarah on Twitter, or email [email protected].If you are still working on this issue, that's fine. Please comment here to tell the bot to give you more time.

Copy link

This issue has been inactive for 417 hours (17.38 days) and is past the limit of 408 hours (17.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you for your interest in contributing to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experience: Backend good first issue A good issue for anyone new to open source to work on hacktoberfest Good issue for someone to work on for Hacktoberfest help wanted We'd love to have help working on this issue Type: Maintenance
Projects
Development

Successfully merging a pull request may close this issue.

2 participants