Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add appstudio redhat nstemplatetier #755

Closed
wants to merge 1 commit into from
Closed

Add appstudio redhat nstemplatetier #755

wants to merge 1 commit into from

Conversation

jinqi7
Copy link

@jinqi7 jinqi7 commented Jun 28, 2023

No description provided.

@jinqi7 jinqi7 marked this pull request as draft June 28, 2023 04:04
@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jinqi7
Once this PR has been reviewed and has the lgtm label, please assign sbryzak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

Hi @jinqi7. Thanks for your PR.

I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jinqi7 jinqi7 force-pushed the appstudio-redhat branch from 7f662b9 to 437abd7 Compare June 28, 2023 04:12
@jinqi7 jinqi7 marked this pull request as ready for review June 28, 2023 04:38
@openshift-ci openshift-ci bot requested a review from xcoulon June 28, 2023 04:38
@jinqi7 jinqi7 force-pushed the appstudio-redhat branch 3 times, most recently from d0d7a46 to 5e8aae4 Compare June 28, 2023 13:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jinqi7 jinqi7 force-pushed the appstudio-redhat branch 3 times, most recently from e261e63 to 3fb8d8a Compare June 30, 2023 12:48
@jinqi7 jinqi7 force-pushed the appstudio-redhat branch from 3fb8d8a to 993b3b6 Compare July 1, 2023 13:54
MatousJobanek
MatousJobanek requested changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeready-toolchain/host-operator#830 (review)

@jinqi7 jinqi7 force-pushed the appstudio-redhat branch from 993b3b6 to 0963c87 Compare July 4, 2023 01:41
@jinqi7 jinqi7 force-pushed the appstudio-redhat branch from 0963c87 to 959d2a8 Compare July 4, 2023 02:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jinqi7 jinqi7 marked this pull request as draft July 4, 2023 12:48
@alexeykazakov
Copy link
Contributor

codeready-toolchain/host-operator#830 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatousJobanek MatousJobanek MatousJobanek requested changes

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov alexeykazakov is a code owner

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan will be requested when the pull request is marked ready for review rajivnathan is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 will be requested when the pull request is marked ready for review ranakan19 is a code owner

@mfrancisc mfrancisc Awaiting requested review from mfrancisc mfrancisc will be requested when the pull request is marked ready for review mfrancisc is a code owner

Assignees
No one assigned
Labels
do-not-merge/work-in-progress needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jinqi7 @alexeykazakov @MatousJobanek @openshift-merge-robot