Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There was an error when the code page could not be obtained #2

Open
wll8 opened this issue Jun 17, 2022 · 5 comments
Open

There was an error when the code page could not be obtained #2

wll8 opened this issue Jun 17, 2022 · 5 comments

Comments

@wll8
Copy link

wll8 commented Jun 17, 2022

image

image

There was an error when the code page could not be obtained
@coderaiser
Copy link
Owner

I thinking about dropping support of such codepages, it worked on Windows XP which is no longer supported by newest node.js, but I don’t have Windows right now. What Windows are you use? Are you willing for a PR with a fix?

@wll8
Copy link
Author

wll8 commented Jun 17, 2022

I am using win10. The question is, is cpcp437 a correct code page? or cp437 ?

@coderaiser
Copy link
Owner

I think cp437 is correct.

@wll8
Copy link
Author

wll8 commented Jun 17, 2022

so? const CHCP = 'cp437'; => const CHCP = '437';

@coderaiser
Copy link
Owner

so? const CHCP = 'cp437'; => const CHCP = '437';

Yes! And would be great to have a test for it, so bug never occur again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coderaiser @wll8