You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The JavaDoc of the ‘bias’ parameter in InteractionDialog.showPopupDialog(Rectangle rect, boolean bias) is not very clear, but if I understand it correctly it doesn’t actually to determine if the ID is shown above or below the component it points to. Shai confirmed this is a bug.
I would also recommend to rename 'bias' to something clear (I guess the unclear name may be a reason for the originally intended behavior getting lost along the way). E.g. prioritizeTopOrRightPosition (assuming this was the original intended meaning).
An alternative could be to change bias to ‘prioritizedPosition’ taking as value Component.TOP/BOTTOM/LEFT/RIGHT and placing the ID there when there’s space enough.
To Reproduce
Create a centered component like a label and show it centered vertically in portrait mode. Then create an InteractionDialog and call showPopupDialog with the component and bias as true or false. The ID is shown in the same place no matter the value of bias.
Expected behavior
See the description.
The text was updated successfully, but these errors were encountered:
Describe the bug
The JavaDoc of the ‘bias’ parameter in InteractionDialog.showPopupDialog(Rectangle rect, boolean bias) is not very clear, but if I understand it correctly it doesn’t actually to determine if the ID is shown above or below the component it points to. Shai confirmed this is a bug.
I would also recommend to rename 'bias' to something clear (I guess the unclear name may be a reason for the originally intended behavior getting lost along the way). E.g. prioritizeTopOrRightPosition (assuming this was the original intended meaning).
An alternative could be to change bias to ‘prioritizedPosition’ taking as value Component.TOP/BOTTOM/LEFT/RIGHT and placing the ID there when there’s space enough.
To Reproduce
Create a centered component like a label and show it centered vertically in portrait mode. Then create an InteractionDialog and call showPopupDialog with the component and bias as true or false. The ID is shown in the same place no matter the value of bias.
Expected behavior
See the description.
The text was updated successfully, but these errors were encountered: