Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify and normalize the compliance-check phase #3772

Open
ddyer0 opened this issue Dec 6, 2023 · 0 comments
Open

simplify and normalize the compliance-check phase #3772

ddyer0 opened this issue Dec 6, 2023 · 0 comments

Comments

@ddyer0
Copy link
Contributor

ddyer0 commented Dec 6, 2023

The current compliance check uses an ad-hoc search to find sources newer than the previous compliance-check,
as an optimization to skip redundant check. This ad-hoc knowlege of the source hierarchy doesn't mesh with the
rest of maven, and is incompatible with using maven to structure projects except exaxtly as codename1 currently
does it.

I propose that compliance-check should instead check the dates of the .classes that are actually going to
be checked. This would be simpler, and also compatible with other project structures.

I note that the proguard phase already works this way.

@ddyer0 ddyer0 changed the title simply and normalize the compliance-check phase simplify and normalize the compliance-check phase Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant