Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password accepts three character #207

Open
hazardemircan opened this issue Oct 8, 2022 · 7 comments
Open

Password accepts three character #207

hazardemircan opened this issue Oct 8, 2022 · 7 comments
Assignees
Labels
bug Something isn't working hacktoberfest Issues for hacktoberfest

Comments

@hazardemircan
Copy link

hazardemircan commented Oct 8, 2022

When sign up, password should be at least 6 char but accepts 3 char

@hazardemircan
Copy link
Author

You can assign to me i can fix it

@padmajabhol padmajabhol added bug Something isn't working hacktoberfest Issues for hacktoberfest labels Oct 11, 2022
@padmajabhol
Copy link
Member

any updates on this @hazardemircan ?

@hazardemircan
Copy link
Author

hazardemircan commented Oct 26, 2022

@padmajabhol sorry for delay my work was very busy i couldn't work on this. I will work on this today after work

@yujit2003
Copy link

@padmajabhol Please assign this to me

@nayabatir1
Copy link

Hey @padmajabhol,
I looked though source code and couple of things feel strange.

  • password length is checked after network response.
  • a lot of state declaration for form values and error.
  • mix of native form and custom validation is being used.

I can restructure the forms and use React-Hook-form which is a great library for managing form values.

@ranaji038
Copy link

@padmajabhol Please Assign this issue to me

@khushigarg1
Copy link

I would like to work on this issue. Can you assign this issue to me ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Issues for hacktoberfest
Projects
None yet
Development

No branches or pull requests

6 participants