Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add IntBoolCast for Entity #6348

Merged
merged 3 commits into from
Aug 10, 2022
Merged

feat: add IntBoolCast for Entity #6348

merged 3 commits into from
Aug 10, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 6, 2022 •
edited
Loading

Description

  • add IntBoolCast ('int-bool') for Entity

From codeigniter4/shield#339

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.3 labels Aug 6, 2022
@MGatner
Copy link
Member

MGatner commented Aug 6, 2022 •
edited
Loading

@rmilecki #5944

@kenjis kenjis force-pushed the feat-int-bool-cast branch from 95072b8 to dd077aa Compare August 9, 2022 00:28
@kenjis
Copy link
Member Author

kenjis commented Aug 9, 2022

Added the docs, and changed the handler name to int-bool.
Because json-arrayalready exists.

@kenjis kenjis requested a review from MGatner August 9, 2022 00:33
MGatner
MGatner approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 4649b0a into codeigniter4:4.3 Aug 10, 2022
@kenjis kenjis deleted the feat-int-bool-cast branch August 10, 2022 02:46
@datamweb datamweb mentioned this pull request Nov 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.3 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan