-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New connection settings Connection Timeout
field
#2443
Conversation
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
👋 A new build is available for this PR based on a2c3496. |
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Thanks @julesyan ! As for the odd behavior, I think I found what the "issue" is. Spoiler alert: it's not a bug, it's a feature. 😅 To try to prevent this from happening, I moved the field to the bottom of the form. Since it used to be in the middle, it was natural to use the wheel to scroll down to the Give it a try and let me know how it goes! |
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
I changed the type of the SSH port number field to a "number" input, so there's a better check on the value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good aside from if i have an invalid value for the timeout, then use the scroll or up/down arrows on the field, it does not revalidate that data, it stays as an error
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
@julesyan it should be OK now. I used a more global event to catch changes in any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Much obliged @julesyan 🙏🏻 |
Changes
Resolves #2442 and #2440.
This PR adds a new
readyTimeout
field to the connection settings (i.e. to theConnectionData
type). This field is described here.A new
number
input has been added to the Connection/Login Settings to manage this field:The
CustomUI
class has been enhanced to support thenumber
input type as well as itsmin
andmax
attributes.The SSH port field has been turned into a
number
input.How to test this PR
Connection Timeout
field to 1000 (i.e. 1 second)Connection Timeout
field to 5000Checklist