Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters with multiple libraries broken #2405

Open
dave-weissman-pcr opened this issue Dec 6, 2024 · 16 comments · Fixed by #2407
Open

Filters with multiple libraries broken #2405

dave-weissman-pcr opened this issue Dec 6, 2024 · 16 comments · Fixed by #2407
Assignees
Labels
bug A confirmed issue when something isn't working as intended due-release Done, due release

Comments

@dave-weissman-pcr
Copy link

Type: Bug

This used to work and has stopped working. I have a comma separated list of libraries.

Extension version: 2.14.5
VS Code version: Code 1.95.3 (f1a4fb101478ce6ec82fe9627c43efbf9e98c813, 2024-11-13T14:50:04.152Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info
Item Value
CPUs 13th Gen Intel(R) Core(TM) i7-13800H (20 x 2918)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Load (avg) undefined
Memory (System) 31.59GB (11.52GB free)
Process Argv --crash-reporter-id 2f019281-5e42-4fb5-8cc5-2cecaf354ddc
Screen Reader no
VM 0%
A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
dvdeprecation:31068756
dwnewjupyter:31046869
nativerepl2:31139839
pythonrstrctxt:31112756
nativeloc1:31192215
cf971741:31144450
iacca1:31171482
notype1:31157159
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530

@Gregory1701
Copy link

@sebjulliand @worksofliam - Hey guys, I've noticed this as well. Any ideas?

@worksofliam
Copy link
Contributor

@Gregory1701 Any chance you can send a screenshot of your configuration and the output tab after the list doesn't show?

@dave-weissman-pcr
Copy link
Author

dave-weissman-pcr commented Dec 6, 2024

In the picture I show 3 filters.

  • the 1st has 2 libraries and expanding it shows nothing
  • the 2nd has 1 library and expanding it shows QRPGLESRC
  • the 3RD has 1 library and expanding it also shows QRPGLESRC

image
image

Below is the output from when it shows nothing.

/home/PGMDAVE: /home/PGMDAVE/.vscode/cqsh_1 -c "system \"call QSYS/QZDFMDB2 PARM('-d' '-i' '-t')\""
select    OBJNAME          as NAME,   OBJTYPE          as TYPE,   OBJATTRIBUTE     as ATTRIBUTE,   OBJTEXT          as TEXT,   0                as IS_SOURCE,   IASP_NUMBER      as IASP_NUMBER,   OBJSIZE          as SIZE,   extract(epoch from (OBJCREATED))*1000       as CREATED,   extract(epoch from (CHANGE_TIMESTAMP))*1000 as CHANGED,   OBJOWNER         as OWNER,   OBJDEFINER       as CREATED_BY from table(QSYS2.OBJECT_STATISTICS(OBJECT_SCHEMA => 'QSYS', OBJTYPELIST => '*LIB'))
{
    "code": 0,
    "signal": null,
    "stdout": "DB2>\n  ?>\n\nNAME       TYPE     ATTRIBUTE  TEXT                                               IS_SOURCE   IASP_NUMBER  SIZE              CREATED              CHANGED              OWNER      CREATED_BY \n---------- -------- ---------- -------------------------------------------------- ----------- ------------ ----------------- -------------------- -------------------- ---------- -----------\nQSYS       *LIB     PROD       System Library                                               0            0         56537088         1530167527000        1733504532000 QSYS       *IBM       \n\n  1 RECORD(S) SELECTED.",
    "stderr": ""
}

@sebjulliand
Copy link
Collaborator

Do you remember after which update it stopped working?

@dave-weissman-pcr
Copy link
Author

Unfortunately I cannot say for sure but most likely a recent update.

@Gregory1701
Copy link

@sebjulliand Unfortunately it had been a few months since I needed to use this filter that I have with multiple libraries in it. So I'm not much help with a timeline.

@worksofliam
Copy link
Contributor

@sebjulliand For sure I broke it with the CCSID fixes. I can take a look next week.

@worksofliam worksofliam self-assigned this Dec 7, 2024
@sebjulliand
Copy link
Collaborator

@sebjulliand For sure I broke it with the CCSID fixes. I can take a look next week.

Not sure about that. The behavior may have changed when I rewrote the filters, months ago 😅

@sebjulliand
Copy link
Collaborator

@worksofliam I see the problem...it's indeed related to the CCSID refactoring, the query we use can't list multiple libraries. I'll fix it.

@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Dec 7, 2024
@sebjulliand sebjulliand mentioned this issue Dec 7, 2024
2 tasks
@sebjulliand
Copy link
Collaborator

@Gregory1701 @dave-weissman-pcr a PR is out and the issue should be fixed soon 😉

@worksofliam worksofliam reopened this Dec 8, 2024
@worksofliam worksofliam added the due-release Done, due release label Dec 8, 2024
@dave-weissman-pcr
Copy link
Author

Awesome...thank you!

@jkdavew
Copy link

jkdavew commented Dec 11, 2024

With the fix in the repo, presumably the next step is to get this deployed to the Marketplace. Do you know the expected timing of that portion?

@worksofliam
Copy link
Contributor

@jkdavew Fingers crossed by the end of the week.

@dave-weissman-pcr
Copy link
Author

Hi - touching base to see the plan for when this will be available in VSCode. Thanks!

@sebjulliand
Copy link
Collaborator

You can already try it if you switch to the pre-release that was published last December 17th. The PR made its way in it.
Here is an article in case you wonder how to do this switch.

@dave-weissman-pcr
Copy link
Author

Thank you - I didn't know about this feature but I just enabled the pre-release version and it worked! Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended due-release Done, due release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants