Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Data Importer I should be able to only import valid CSV files #64

Open
T-Dnzt opened this issue Aug 24, 2022 · 0 comments
Open

As a Data Importer I should be able to only import valid CSV files #64

T-Dnzt opened this issue Aug 24, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@T-Dnzt
Copy link
Collaborator

T-Dnzt commented Aug 24, 2022

Overview

The current Data Set import works well when the imported CSV files are in the expected format and the mapping is done properly. However, it lacks some validation steps to prevent the import of invalid CSV files and the mapping of fields to the wrong types.

This issue lists solutions for the problems encountered by the team when importing CSV files.

Improvements

  • Switch to a Ruby CSV parser to make the steps below easier, and the whole process easier to test.
  • Validate the CSV file format to ensure it will be properly imported into the system.
  • Ensure one of the fields in the CSV is mapped to "Detailed call type" to enable the classification flow.
  • Validate the mappings. For example, validate that if a field is mapped to the "Call Time" type, it contains a valid datetime and avoid trying to parse invalid data (which currently crashes the application).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Needs Approval
Development

No branches or pull requests

4 participants