Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/QRCoder2] Consider Removing Nested Types from Public API Signatures #555

Closed
Tracked by #512
csturm83 opened this issue May 28, 2024 · 2 comments
Closed
Tracked by #512
Labels
qrcoder2 Everything related to QRCoder v2

Comments

@csturm83
Copy link
Contributor

MS design guidelines on the use of Nested Types suggests that they should be used sparingly and avoided in public API (amongst other recommendations).

PayloadGenerator comes to mind as well as some public enums in QRCodeGenerator. The nesting of types could be removed where unnecessary.

@codebude codebude added the qrcoder2 Everything related to QRCoder v2 label May 28, 2024
@codebude
Copy link
Owner

I don't think there's anything to add here. Where it makes sense, we can remove/unnest the nested types.

@codebude
Copy link
Owner

I added this as "decision" to the descision post of the meta issue. Thus I'll close this issue here, so that we can mark it as completed/decided in the "things to discuss" list here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qrcoder2 Everything related to QRCoder v2
Projects
None yet
Development

No branches or pull requests

2 participants