Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 questions 1.4.2 & 1.4.3 on ArtQRCode-Renderer #367

Closed
AlexandreZaytsev opened this issue Dec 23, 2021 · 2 comments
Closed

2 questions 1.4.2 & 1.4.3 on ArtQRCode-Renderer #367

AlexandreZaytsev opened this issue Dec 23, 2021 · 2 comments
Labels

Comments

@AlexandreZaytsev
Copy link

AlexandreZaytsev commented Dec 23, 2021

Hi!
please take a look

ArtQRCode-Renderer (1.4.2 1.4.3) example of a call method
1.1
when using the drawQuietZones flag for finderPatternImage
true - without offset?
false - ok
image
image

1.2
pixel Size Factor didn't work for me - size (shape)
dots - does not change... what could be the matter?
image

ps
test app source

@AlexandreZaytsev AlexandreZaytsev changed the title 2 questions 1.4.2 & 1.4.3 2 questions 1.4.2 & 1.4.3 on ArtQRCode-Renderer Dec 26, 2021
@AlexandreZaytsev
Copy link
Author

comment on question 1.2 artmode
pixelsPerModule - 2 pixelSizeFactor 0-1
image

pixelsPerModule - 3 pixelSizeFactor 0-1
image

pixelsPerModule - 4 pixelSizeFactor 0-1
image

pixelsPerModule - 5 pixelSizeFactor 0-1
image

pixelsPerModule - 6 pixelSizeFactor 0-1
image

pixelsPerModule - 7 pixelSizeFactor 0-1
image

pixelsPerModule - 8 pixelSizeFactor 0-1
image

etc. - artifacts
the role of the pixelSizeFactor parameter is not clear

if the diameter of the point changed - then yes, otherwise it is not clear why

@codebude
Copy link
Owner

Both bugs mentioned were fixed in #408 and #474 and are part of the recently release QRCoder 1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants