Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug? Cannot submit comments #83

Open
jotaen4tinypilot opened this issue Dec 15, 2022 · 3 comments
Open

Bug? Cannot submit comments #83

jotaen4tinypilot opened this issue Dec 15, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@jotaen4tinypilot
Copy link

jotaen4tinypilot commented Dec 15, 2022

When trying to review tiny-pilot/tinypilot#1191 / https://codeapprove.com/pr/tiny-pilot/tinypilot/1231, I seem to not be able to submit my comments – at least I’m not sure about it, because they don’t show up on Github. The Review Log on the right hand side also shows a bunch of seemingly empty entries. I tried to submit my comments a few times.

Screen.Recording.2022-12-15.at.15.43.36.mov

(Sorry for the low resolution, Github unfortunately only allows uploads <10M)

Here is the JS console output:

Screenshot 2022-12-15 at 15 42 01

@jotaen4tinypilot
Copy link
Author

Update: the comment showed up on Github in the meantime.

@samatcodeapprove samatcodeapprove added the bug Something isn't working label Dec 15, 2022
@samatcodeapprove
Copy link

@jotaen4tinypilot yikes that is not good! Has this issue gone away or is it still happening? And is it limited to one review or is this happening to you across all PRs?

@jotaen4tinypilot
Copy link
Author

I think it only happened in this very instance. Since the comment showed up afterwards, it almost felt as if the submission was temporarily stuck in a queue or so, while the CodeApprove UI suggested it went through successfully, and didn’t give any indication that it wasn’t actually fully processed yet. That way, I intuitively assumed that the submission had failed altogether, and re-submitted multiple times.

In any event, I just tried again on a different review, where I first submitted my comments as “Comment” (like yesterday), and then submitted as “Approval”. Here, it all worked as expected again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants