Persist view settings

[mtlynch]

One of the biggest pain points in using CodeApprove for me is that at the start of every review (or even opening the same review in a new tab) is that I have to configure my view settings manually:

• Sort in file order
• Show changes since my last review
• Expand diffs

It would be great if I could set my view preferences somewhere in my account. Even if the global settings are whatever I've chosen for my last review, that would be helpful.

[samatcodeapprove]

@mtlynch thanks this is a good idea!

How has the performance of "expand all diffs" been for you? One of the reasons that's not the default today is that I found it to be laggy for large reviews, but I also have a very slow computer.

[mtlynch]

How has the performance of "expand all diffs" been for you?

Oh, it's been fine for me.

[samatcodeapprove]

@mtlynch ok I just deployed a small part of this, which is a new entry in settings to set your default file sort order. This is device-local:

I will work on adding the other two settings but those have bigger implications on how data flows through the app (right now I get the first diff before I know the time of your last review) and I want to be very careful when tweaking that core.

[mtlynch]

Cool, thanks! I confirmed the file sort setting is working on my system.