Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider not showing the "Approved" stamp when there are still unresolved comments #43

Open
samatcodeapprove opened this issue Aug 13, 2022 · 0 comments
Open

Consider not showing the "Approved" stamp when there are still unresolved comments #43

samatcodeapprove opened this issue Aug 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@samatcodeapprove
Copy link

The stamp added in #23 should be a celebration / signal that the PR is fully approved. It should not show up on a review which approves with unresolved comments.

(originally requested by @berlinjohnson)
@samatcodeapprove samatcodeapprove added the enhancement New feature or request label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samatcodeapprove