Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github File/Line Comments #107

Open
ianb-pomelo opened this issue Dec 14, 2023 · 1 comment
Open

Github File/Line Comments #107

ianb-pomelo opened this issue Dec 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ianb-pomelo
Copy link

People at our company use a couple different code review tools depending on their preference/prior experience. A couple of us used to work at Google and miss Critque (so CodeApprove is great!) but since we won't have everyone use it due to a preference for the Github UI, we would need to make interop between CodeApprove and the Github UI pretty seamless.

After testing things out, I can't find a way to leave line-level or file-level comments in CodeApprove that are written in Github as line/file level comments. Is this possible?

@samatcodeapprove samatcodeapprove added the enhancement New feature or request label Feb 15, 2024
@samatcodeapprove
Copy link

@ianb-pomelo sorry I never answered you here, this somehow slipped past my Gmail filters. Right now this is not possible because CodeApprove comments are not 1:1 compatible with GitHub. For example in CodeApprove you can comment on any line, not just lines in the diff. GitHub does not allow this.

However you're not the first one to ask for a "GitHub transparency mode" where features like that would be restricted in order to create greater compatibility. This is something I'd like to work on soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants