Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with texts #53

Open
4 tasks
tudoramariei opened this issue Mar 4, 2024 · 4 comments · Fixed by #58
Open
4 tasks

Issues with texts #53

tudoramariei opened this issue Mar 4, 2024 · 4 comments · Fixed by #58
Assignees
@birloiflorian @overeha
Labels
bug 🐛 Something isn't working PR-OPEN

Comments

@tudoramariei
Copy link
Member

tudoramariei commented Mar 4, 2024 •
edited
Loading

Describe the bug

Some texts have not been finished (i.e., they contain lorem ipsums, missing diacritics, and use wrong names)

  • The about page /about
  • The contact page /contact
  • ONG Hub appears in buttons/texts instead of NGO Hub
  • Very few diacritics exist

Screenshots

Screenshot 2024-03-04 at 15 39 02 Screenshot 2024-03-04 at 15 38 28 Screenshot 2024-03-04 at 15 55 17 Screenshot 2024-03-04 at 15 55 50
@tudoramariei tudoramariei added the bug 🐛 Something isn't working label Mar 4, 2024
@dragos1195
Copy link
Contributor

@mirunaioana-msc please provide the correct texts, including diacritics.

@mirunaioana-msc
Copy link
Contributor

mirunaioana-msc commented May 13, 2024 •
edited
Loading

Despre Practice for Good - https://www.figma.com/design/cfixQXmZ7FdFatiDCpUhyK/ONG-HUB?node-id=8202%3A2483&t=iQ5F2l0n0lbWmYFu-1

Pagina contact - https://www.figma.com/design/cfixQXmZ7FdFatiDCpUhyK/ONG-HUB?node-id=8206-18514&t=iQ5F2l0n0lbWmYFu-4

@mirunaioana-msc
Copy link
Contributor

I can add missing diacritics if you give me a link to the json file

@dragos1195 dragos1195 linked a pull request May 14, 2024 that will close this issue
fix: [C4R-57] fix issue 57 #58
Merged
@dragos1195
Copy link
Contributor

Opened PR for issues in the description. For any other diacritics you can use the following JSON https://github.com/code4romania/practice-for-good/blob/main/src/assets/locales/ro/translation.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@birloiflorian birloiflorian

@overeha overeha

Labels
bug 🐛 Something isn't working PR-OPEN
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [C4R-57] fix issue 57 code4romania/practice-for-good
5 participants
@tudoramariei @birloiflorian @dragos1195 @overeha @mirunaioana-msc