Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Pagination Section Cursor Issue #654

Closed
amartripathi0 opened this issue Sep 19, 2024 · 7 comments · Fixed by #655
Closed

bug: Pagination Section Cursor Issue #654

amartripathi0 opened this issue Sep 19, 2024 · 7 comments · Fixed by #655
Labels
enhancement New feature or request

Comments

@amartripathi0
Copy link
Contributor

Description
The pagination section is currently displaying a default cursor on hover instead of a pointer cursor, which can lead to confusion regarding the interactivity of the buttons.

Steps to reproduce

  1. Navigate to the landing page.
  2. Scroll to the bottom of the page to locate the Pagination Section.
  3. Hover over the "Prev," "Next," and other page buttons.
  4. Observe that the cursor remains as a default arrow instead of changing to a pointer.

Current Behaviour (Default cusor on hover)
The cursor does not change on hover, indicating that the buttons are not interactive.
Screenshot from 2024-09-19 13-55-47

Expected Behaviour
The cursor should change to a pointer when hovering over pagination buttons, indicating that they are clickable.
Screenshot from 2024-09-19 13-56-05

Solution
Adding cursor-pointer class to <PaginationItem/> in LandingScreen

@amartripathi0 amartripathi0 added the enhancement New feature or request label Sep 19, 2024
@amartripathi0 amartripathi0 changed the title feature: Pagination Section Cursor Issue bug: Pagination Section Cursor Issue Sep 19, 2024
@jals413
Copy link

jals413 commented Sep 19, 2024

But, the pagination does not work on clicking those buttons, also all the tracks are loaded with scroll, thus pagination is not required

Either one of the should be implemented

#651

@devsargam
Copy link
Collaborator

@jals413 I agree. I will think about it and comeup with something

@jals413
Copy link

jals413 commented Sep 19, 2024

#652

@devsargam

I have created a PR for removing pagination as it does not make any sense here, if you feel so you can merge it.

@devsargam
Copy link
Collaborator

Yeah saw that @jals413

@amartripathi0
Copy link
Contributor Author

@jals413 @devsargam we need to scroll alot to reach the end of the landing page and I guess its not a good UX and idea to display all the tracks as in the future the no. of tracks gonna increase only.

@jals413
Copy link

jals413 commented Sep 21, 2024

I agree, but in my opinion if you want to handle pagination it should be handled from BE then only it will make the true sense

@amartripathi0
Copy link
Contributor Author

yes, that's the optimial way to avoid overfetching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants