Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M-02 MitigationConfirmed #52

Open
c4-bot-10 opened this issue Jun 7, 2024 · 1 comment
Open

M-02 MitigationConfirmed #52

c4-bot-10 opened this issue Jun 7, 2024 · 1 comment
Labels
mitigation-confirmed MR-M-02 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-bot-10
Copy link
Contributor

Lines of code

Vulnerability details

C4 Issue

M-02: code-423n4/2024-04-renzo-findings#569

Issue Details

In WithdrawQueue contract, PausableUpgradable is inherited to provide pausing capabilities to the administrator on users' withdrawals and claims. But it is not implemented in withdraw() and claim() function:

function withdraw(uint256 _amount, address _assetOut) external nonReentrant {
     ...
}

function claim(uint256 withdrawRequestIndex) external nonReentrant {
     ...
}

Mitigation

Mitigation successfully mitigates the original issue by add WhenNotPaused modifier to withdraw() and claim() function.

Conclusion

Mitigation confirmed

c4-bot-10 added a commit that referenced this issue Jun 7, 2024
@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Jun 8, 2024
@c4-judge
Copy link

c4-judge commented Jun 8, 2024

alcueca marked the issue as satisfactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mitigation-confirmed MR-M-02 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

2 participants