Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TCE-1154] Inconsistencies in --registryAddress handling #514

Open
pachuka opened this issue Oct 30, 2024 · 1 comment
Open

[TCE-1154] Inconsistencies in --registryAddress handling #514

pachuka opened this issue Oct 30, 2024 · 1 comment
Labels
jira-issue Issue tracked on JIRA

Comments

@pachuka
Copy link

pachuka commented Oct 30, 2024

Hello, thank you for adding the --registry-address handling flag. I just wanted to point out two issues I noticed when attempting to use this flag:

  1. In bin/codacy-analysis-cli.sh#L46 it looks like we're expecting ${REGISTRY_ADDRESS} available as an environment variable instead of it using the flag? I didn't notice anything about that in the readme/instructions, but without setting that I noticed that when I ran codacy-analysis-cli analyze --registry-address <custom registry url> it was still pulling from the public registry. So I suppose I don't fully understand when the CLI flag applies vs the environment variable. Once I set that variable I saw the behavior I expected

  2. It would be nice if the Makefile/initial setup could also leverage/respect the registry address override:

    curl -L https://github.com/codacy/codacy-analysis-cli/archive/master.tar.gz | tar xvz
    cd codacy-analysis-cli-* && sudo make install
    

It ended up still pulling from docker.io because it's not parameterized here: https://github.com/codacy/codacy-analysis-cli/blob/master/Makefile#L16

I know we can modify it manually before running the install, but just might be a bit unexpected. Maybe that could leverage that same REGISTRY_ADDRESS for that if its already set in the environment?

@pachuka pachuka changed the title Inconsistencies in --registryAddress handling Inconsistencies in --registry-address override handling Oct 30, 2024
@github-actions github-actions bot added the jira-issue Issue tracked on JIRA label Oct 30, 2024
@github-actions github-actions bot changed the title Inconsistencies in --registry-address override handling [TCE-1154] Inconsistencies in --registryAddress handling Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

Internal ticket created : TCE-1154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-issue Issue tracked on JIRA
Projects
None yet
Development

No branches or pull requests

1 participant