Skip to content

Commit

Permalink
[CRDB-44988] bugfix: fix cockroach start arguments
Browse files Browse the repository at this point in the history
The cockroach start command was not accepting any arguments after
--http-port due to whitespace getting introduced in the template.
This PR chomps the whitespace to fix this bug.
  • Loading branch information
pritesh-lahoti committed Nov 28, 2024
1 parent bdc75bf commit 36cabe6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cockroachdb/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ spec:
{{- else }}
--http-port={{ index .Values.service.ports.http.port | int64 }}
{{- end }}
{{ if .Values.conf.port }}
{{- if .Values.conf.port }}
--port={{ .Values.conf.port | int64 }}
{{- else }}
--port={{ .Values.service.ports.grpc.internal.port | int64 }}
Expand Down Expand Up @@ -256,7 +256,7 @@ spec:
{{- end }}
ports:
- name: grpc
{{ if .Values.conf.port }}
{{- if .Values.conf.port }}
containerPort: {{ .Values.conf.port | int64 }}
{{- else }}
containerPort: {{ .Values.service.ports.grpc.internal.port | int64 }}
Expand Down Expand Up @@ -349,7 +349,7 @@ spec:
{{- else }}
emptyDir: {}
{{- end }}
{{ with .Values.statefulset.volumes }}
{{- with .Values.statefulset.volumes }}
{{ toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.tls.enabled }}
Expand Down

0 comments on commit 36cabe6

Please sign in to comment.