sql/tests: TestRandomSyntaxGeneration failed

[cockroach-teamcity]

sql/tests.TestRandomSyntaxGeneration failed with artifacts on release-24.3 @ ebd6bb6875e56ef3005f30d3ef46d4259ed40037:

*   | 	pkg/sql/sem/tree/type_check.go:345
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.TypeCheckAndRequire
*   | 	pkg/sql/sem/tree/type_check.go:355
*   | github.com/cockroachdb/cockroach/pkg/sql.(*planner).analyzeExpr
*   | 	pkg/sql/analyze_expr.go:34
*   | github.com/cockroachdb/cockroach/pkg/sql.(*planner).planTenantSpec
*   | 	pkg/sql/tenant_spec.go:63
*   | github.com/cockroachdb/cockroach/pkg/sql.(*planner).LookupTenantInfo
*   | 	pkg/sql/tenant_spec.go:148
*   | github.com/cockroachdb/cockroach/pkg/ccl/crosscluster/physical.alterReplicationJobHook.func1
*   | 	pkg/ccl/crosscluster/physical/alter_replication_job.go:220
*   | github.com/cockroachdb/cockroach/pkg/sql.(*hookFnNode).startExec.func1
*   | 	pkg/sql/planhook.go:194
*   | github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2
*   | 	pkg/util/stop/stopper.go:498
*   | runtime.goexit
*   | 	src/runtime/asm_amd64.s:1695
* Wraps: (4) ReturnType called on TypedExpr with empty typeAnnotation. Was the underlying Expr type-checked before asserting a type of TypedExpr?
* Error types: (1) *withstack.withStack (2) *assert.withAssertionFailure (3) *withstack.withStack (4) *errutil.leafError
*
panic: ReturnType called on TypedExpr with empty typeAnnotation. Was the underlying Expr type-checked before asserting a type of TypedExpr? [recovered]
	panic: ReturnType called on TypedExpr with empty typeAnnotation. Was the underlying Expr type-checked before asserting a type of TypedExpr?

goroutine 1443437 [running]:
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).recover(0x454705?, {0x886b830, 0xc010dccd50})
	pkg/util/stop/stopper.go:226 +0x65
panic({0x6890720?, 0xc01c16ce60?})
	GOROOT/src/runtime/panic.go:770 +0x132
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.typeAnnotation.assertTyped(...)
	pkg/sql/sem/tree/expr.go:148
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*Subquery).TypeCheck(0x42ddf8?, {0x3fc3333333333333?, 0xc002191d40?}, 0x886b830?, 0xcc0000c029bd8ff0?)
	pkg/sql/sem/tree/type_check.go:1754 +0xd3
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.TypeCheck({0x886b830?, 0xc010dccd50?}, {0x886c6d8?, 0xc010dcc540?}, 0x6f6e92e?, 0xc0013b57d0?)
	pkg/sql/sem/tree/type_check.go:345 +0x8a
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.TypeCheckAndRequire({0x886b830?, 0xc010dccd50?}, {0x886c6d8?, 0xc010dcc540?}, 0xc002405c00?, 0xc8ad360, {0x7032882, 0x21})
	pkg/sql/sem/tree/type_check.go:355 +0x54
github.com/cockroachdb/cockroach/pkg/sql.(*planner).analyzeExpr(0xc00cb33bb8, {0x886b830, 0xc010dccd50}, {0x886c6d8?, 0xc010dcc540?}, {{0x0, 0x0, 0x0}, {0x0, 0x0}}, ...)
	pkg/sql/analyze_expr.go:34 +0xaf
github.com/cockroachdb/cockroach/pkg/sql.(*planner).planTenantSpec(0xc010dccd50?, {0x886b830?, 0xc010dccd50?}, 0x1e?, {0x7032882?, 0x4000000000000000?})
	pkg/sql/tenant_spec.go:63 +0x190
github.com/cockroachdb/cockroach/pkg/sql.(*planner).LookupTenantInfo(0xc00cb33bb8, {0x886b830, 0xc010dccd50}, 0x8849060?, {0x7032882?, 0x0?})
	pkg/sql/tenant_spec.go:148 +0x27
github.com/cockroachdb/cockroach/pkg/ccl/crosscluster/physical.alterReplicationJobHook.func1({0x886b830, 0xc010dccd50}, {0xc002405f84?, 0xc002405e90?, 0xd56994?}, 0xc021c34ba0)
	pkg/ccl/crosscluster/physical/alter_replication_job.go:220 +0x159
github.com/cockroachdb/cockroach/pkg/sql.(*hookFnNode).startExec.func1({0x886b830, 0xc010dccd50})
	pkg/sql/planhook.go:194 +0x4a
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2({0x6fd00f3?, 0x0?})
	pkg/util/stop/stopper.go:498 +0x1f0
created by github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx in goroutine 1443295
	pkg/util/stop/stopper.go:488 +0x49c

Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

• sql/tests: TestRandomSyntaxGeneration failed [Alter PCR Stream] #135784 sql/tests: TestRandomSyntaxGeneration failed [Alter PCR Stream] [A-disaster-recovery C-test-failure O-robot T-disaster-recovery branch-release-24.2 release-blocker]
• sql/tests: TestRandomSyntaxGeneration failed [CREATE TENANT statement is not valid after parsing then formatting] #132558 sql/tests: TestRandomSyntaxGeneration failed [CREATE TENANT statement is not valid after parsing then formatting] [C-test-failure O-robot P-2 T-db-server branch-release-24.1.6-rc]

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-44948