From ca2b68b12714a85cb51b7e8446a35b343ca478c2 Mon Sep 17 00:00:00 2001 From: Simon Kobyda Date: Mon, 14 Aug 2023 14:58:04 +0200 Subject: [PATCH] Replace deprecated font redhat--monospace with basic PF's monospace PF dropped pf-v5-global--FontFamily--redhat--monospace since patternfly/patternfly@4ec21e34fc3 --- src/machines.scss | 2 +- test/check-machines-disks | 6 ++++++ test/reference | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/machines.scss b/src/machines.scss index 8cc90482b..5060b439a 100644 --- a/src/machines.scss +++ b/src/machines.scss @@ -81,7 +81,7 @@ } .ct-monospace { - font-family: var(--pf-v5-global--FontFamily--redhat--monospace); + font-family: var(--pf-v5-global--FontFamily--monospace); } // Do not add a box-shadow to a "subsection", while it's technically correct it looks weird. diff --git a/test/check-machines-disks b/test/check-machines-disks index 6eb957bd9..7bf6475e7 100755 --- a/test/check-machines-disks +++ b/test/check-machines-disks @@ -302,6 +302,7 @@ class TestMachinesDisks(VirtualMachinesCase): pool_name=None, volume_name=None, file_path=None, force=False, + pixel_tag=None, ): self.test_obj = test_obj self.mode = mode @@ -311,6 +312,7 @@ class TestMachinesDisks(VirtualMachinesCase): self.volume_name = volume_name self.target = target self.force = force + self.pixel_tag = pixel_tag def _get_disks(self): m = self.test_obj.machine @@ -403,6 +405,9 @@ class TestMachinesDisks(VirtualMachinesCase): b.click(f"#vm-{self.vm_name}-disks-{self.target}-eject-button") # button b.wait_in_text(".pf-v5-c-modal-box__title", "Eject disc from VM") + if self.pixel_tag: + b.assert_pixels(".pf-v5-c-modal-box", self.pixel_tag) + if self.mode == "custom-path": b.wait_in_text(f"#vm-{self.vm_name}-disks-{self.target}-modal-description-file", self.file_path) elif self.mode == "use-existing": @@ -1632,6 +1637,7 @@ class TestMachinesDisks(VirtualMachinesCase): mode='custom-path', target='sda', file_path='/var/lib/libvirt/novell.iso', + pixel_tag='vm-disc-eject-modal', ).execute() self.VMInsertMediaDialog( diff --git a/test/reference b/test/reference index 85f5d7aa3..21a39ee20 160000 --- a/test/reference +++ b/test/reference @@ -1 +1 @@ -Subproject commit 85f5d7aa3d629c80af2cdf8ac18fa1330c6b018f +Subproject commit 21a39ee203617464c3c5a95e60b50d660b91bbb4