Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When commit messages contains mismatch of " and special characters ( or ), then the manual_deploy part of on push fails #7

Open
VWJF opened this issue Sep 2, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@VWJF
Copy link
Collaborator

VWJF commented Sep 2, 2022

Same as Issue 4 of srkw-call-catalogue-files

I suspect it is because the payload sends commit messages, and some messages contain characters ", ( and ), ' which are being echoed without escaping in the manual deployment action


The issue does not occur with

  • manually triggered deployment
  • The automatically triggered GH Webhook feature (Settings -> Webhook -> on push)
    • The limitation of the webhook is that response status messages are not sent back since the token is missing in its payload
@VWJF VWJF added the bug Something isn't working label Sep 2, 2022
@VWJF VWJF changed the title When commit messages contains mismatch of " and special characters ( or ), then the manual_deploy part of on push fails #4 When commit messages contains mismatch of " and special characters ( or ), then the manual_deploy part of on push fails Sep 2, 2022
@VWJF
Copy link
Collaborator Author

VWJF commented Sep 12, 2022

In the earlier step, the output variable is set with

echo "::set-output name=packageJson::$content"

This echo was removed one level of the escaping of symbols \' became '

Instead, use jq to achieve URL encoding https://stackoverflow.com/a/34407620

content=`cat $GITHUB_EVENT_PATH` | jq -sRr @uri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant