Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Tests #43

Open
cnguy opened this issue Jan 3, 2018 · 0 comments
Open

Integration Tests #43

cnguy opened this issue Jan 3, 2018 · 0 comments
Labels
in-progress

Comments

@cnguy
Copy link
Owner

cnguy commented Jan 3, 2018 •
edited
Loading

Create more integration tests that work off fixtures (values do not have to be exactly equal. for example, if a fixture has a summoner that was level 30, but they are now 31, you can simply assert restApiData.level >= fixture.level).

These tests will not be ran on Travis due to hanging, but this is fine as the tests can just be ran locally for anyone interested.
cnguy added a commit that referenced this issue Jan 3, 2018
@cnguy
chore: Setup package.json to have test-integration command #43
05215a9
cnguy added a commit that referenced this issue Jan 3, 2018
@cnguy
test (Summoner): Modify summoner test to be more robust and add READM…
ca9a0d1 
…E explaining process #43
cnguy added a commit that referenced this issue Jan 3, 2018
@cnguy
test (Challenger@Integration): Add success test + 400 bad request tes…
94837c3 
…t for challenger league response #43
cnguy added a commit that referenced this issue Jan 3, 2018
@cnguy
test (Matchlist@Integration): Add matchlist integration tests (with q…
d6b7e3c 
…uery parameter tests too) #43
cnguy added a commit that referenced this issue Jan 3, 2018
@cnguy
test (Match@Integration): Add match tests (also test for different re…
f618d47 
…gion) #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in-progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cnguy