Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvements to grouping and sorting performance #56

Open
DanielLiamAnderson opened this issue Apr 25, 2023 · 0 comments
Open
Labels
performance Performance is worse than it should be

Comments

@DanielLiamAnderson
Copy link
Contributor

group_by_key

The performance of group_by_key sometimes suffers on multi-socket machines, despite scaling fine on a single socket. Its implementation could possibly be improved. group_by_key_sorted does not seem to have this issue, so perhaps it could be used as a fallback to make group_by_key faster.

sample_sort

The example implementation of sample sort in the example code here is sometimes (but not always) faster than the actual sample sort implementation in the library, despite being substantially simpler. We could improve the library implementation by borrowing some of the example code.

@DanielLiamAnderson DanielLiamAnderson added the performance Performance is worse than it should be label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance is worse than it should be
Projects
None yet
Development

No branches or pull requests

1 participant