Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

fix: return error when fail to pull data from stream in disk manager #47

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

xx01cyx
Copy link
Member

@xx01cyx xx01cyx commented Apr 26, 2024

As title.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.98%. Comparing base (73a50e3) to head (37355b0).

Files Patch % Lines
storage-node/src/disk/disk_manager.rs 82.35% 2 Missing and 1 partial ⚠️
...age-node/src/cache/data_store_cache/memdisk/mod.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   89.08%   88.98%   -0.10%     
==========================================
  Files          17       17              
  Lines        2116     2116              
  Branches     2116     2116              
==========================================
- Hits         1885     1883       -2     
  Misses        121      121              
- Partials      110      112       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lanlou1554
Copy link
Collaborator

LGTM

@xx01cyx xx01cyx merged commit 271c97c into main Apr 26, 2024
1 check passed
@unw9527 unw9527 deleted the yx/fix-disk-manager branch April 30, 2024 00:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants