Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preselection: Tool for making data/MC plots #3

Open
sam-may opened this issue Feb 5, 2021 · 5 comments
Open

Preselection: Tool for making data/MC plots #3

sam-may opened this issue Feb 5, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@sam-may
Copy link
Collaborator

sam-may commented Feb 5, 2021

Implement script (e.g. make_plots.py) that takes a dataframe (output from the looper) as input and makes various plots.

Ideal configurable options:

  • Input dataframe
  • Type of plot: data/MC plot OR shape comparison
  • Linear vs. log axis (hopefully the script also calculates reasonable axis ranges)
  • Include/don't include ratio pad
  • List of variables to make plots for. For this, a json file is my first idea at making this easily configurable. Can contain a list of variables along with relevant data for each (binning, axis limits, additional text to print on plot, etc)

Configurable options for data/MC plots:

  • List of samples to consider as backgrounds (plot these as stacked histograms)
  • List of samples to consider as signals (plot these as solid lines)
  • Normalization of background: scale by lumi or scale total background to data

I know there are many different plotting packages already out there, and I am relatively ignorant about them, so please comment if you have one in mind that is the best/most user-friendly/etc. These would probably be a good starting point for the script and might save a majority of the work.

@sam-may sam-may added the enhancement New feature or request label Feb 5, 2021
@mhl0116
Copy link
Collaborator

mhl0116 commented Feb 5, 2021

I suggest we start from this:
https://github.com/aminnj/pdroot

@bsathian bsathian self-assigned this Feb 8, 2021
@bsathian
Copy link
Contributor

bsathian commented Feb 8, 2021

okay I'll take this task up. I need a plotter script for the BDT input variables anyways

@sam-may
Copy link
Collaborator Author

sam-may commented Feb 12, 2021

@bsathian plotter looks nice, can you make a dir plots_and_tables under Preselection and put relevant files there?

@bsathian
Copy link
Contributor

bsathian commented Feb 12, 2021 via email

@bsathian
Copy link
Contributor

bsathian commented Feb 13, 2021

Done. Please review and close the issue if things look good

@bsathian bsathian reopened this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants