-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 2 GTT Add Extended Jets to buffers for GlobalTrigger #1248
base: phase2-l1t-integration-14_0_0_pre3
Are you sure you want to change the base?
Phase 2 GTT Add Extended Jets to buffers for GlobalTrigger #1248
Conversation
If this gets approved, maintainers feel free to convert the PR to master from Draft (or I can do so whenever); no expected changes except ones needed here. |
@NJManganelli I would take this straight to CMSSW. I am hopeful that we are going to add in a bunch of muon PRs and then close v9 and this round of phase 2 AR upgrades. I don't want this to just languish here, so just having it in central CMSSW will be the the quickest way to get it into the next AR IB (If one gets made, if I have my way we will make this whole fork obsolete in favor of just operating in central CMSSW). |
Getting rid of IB(s) would be great! I'll convert the master PR to fully open |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no issues with the code checks!
I found no issues with the headers!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found 2 files that did not meet formatting requirements:
Please run
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. This PR passes available unit tests!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation I found a non-zero return code running the relval workflows for this PR!
|
PR description:
This PR adds the GTT Displaced TrackJets into the emulation buffers from GTT to GlobalTrigger
As with the PR to add displaced HT, this is not time-critical, but also does not affect workflows for the AR (only being called by GTT F/W Emulation buffer workflow, createFirmwareInputFiles_cfg.py)
PR validation:
scram b code-checks
scram b code-format
scram b
cmsRun createFirmwareInputFiles_cfg.py maxEvents=1000 format=APx inputFiles=... --> inserts Displaced TrackJet words into GTT buffers for OutputToGlobalTrigger
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This will need a forward-port to master