-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add clusterpedia openapi and bump k8s dependency to v1.28.2 #579
Conversation
Hi @wawa0210, DetailsInstructions for interacting with me using comments are available here. |
9091236
to
88c48f4
Compare
3676498
to
008d42b
Compare
...erpedia/staging/src/github.com/clusterpedia-io/api/cluster/v1alpha2/zz_generated.deepcopy.go
Outdated
Show resolved
Hide resolved
It is recommended that the commit message and pr title be changed to be specific version
|
0f7b834
to
4c232df
Compare
Signed-off-by: wawa0210 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution
What type of PR is this?
/kind flake
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The reason for adding ignored static check SA1019 is that a method is marked as deprecated, but the changes are relatively large and have not been changed yet. Later we can try to modify PR alone .The detailed error is as follows
detail link --> href
relation code
clusterpedia/pkg/synchromanager/clustersynchro/informer/reflector.go
Line 167 in e788be4
clusterpedia/pkg/synchromanager/clustersynchro/informer/cache/.reflector.go
Line 182 in e788be4
Does this PR introduce a user-facing change?: