Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Carbon Components Svelte v1.0.0 #66

Open
n-peugnet opened this issue Jan 15, 2024 · 0 comments
Open

Upgrade to Carbon Components Svelte v1.0.0 #66

n-peugnet opened this issue Jan 15, 2024 · 0 comments
Labels
blocked This issue is blocked by something dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@n-peugnet
Copy link
Member

n-peugnet commented Jan 15, 2024

This is a major change to Carbon Components Svelte as it also upgrades the Carbon stylesheet from v10 to v11. It is not released yet, but we can already try to see if anything breaks or if we will need to change some things.

See carbon-design-system/carbon-components-svelte#1614

Svelte projects consuming carbon-components-svelte will need to include SCSS preprocessors.

This is interesting as it will allow use to fix #58 in a proper way, as I imagined initially, by setting the $font-path parameter to an appropriate value. This in turn will allow to get rid of rollup-plugin-bundle-fonts introduced in 635ad42, and probably also the commonjs loader as I think it is the only non ES module of the project (and newer project are almost all ES modules).

@n-peugnet n-peugnet added enhancement New feature or request blocked This issue is blocked by something dependencies Pull requests that update a dependency file labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue is blocked by something dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant