From 83fd1d5d514ad200fd4d553874e543c1701eda8d Mon Sep 17 00:00:00 2001 From: rogerogers <rogers@rogerogers.com> Date: Wed, 28 Feb 2024 16:43:46 +0800 Subject: [PATCH] chore: set lint go version Signed-off-by: rogerogers <rogers@rogerogers.com> --- .github/workflows/pr-check.yml | 6 +----- gomall/app/product/biz/model/product.go | 1 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index bdcc3040..88618eae 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -33,15 +33,11 @@ jobs: strategy: matrix: ${{ fromJson(needs.resolve-modules.outputs.matrix) }} steps: - - name: Set up Go - uses: actions/setup-go@v4 - with: - go-version: 1.21 - uses: actions/checkout@v3 - name: Lint uses: golangci/golangci-lint-action@v3 with: version: latest working-directory: ${{ matrix.workdir }} - args: --timeout 30m -E gofumpt + args: --timeout 30m -E gofumpt --go 1.21 skip-pkg-cache: true diff --git a/gomall/app/product/biz/model/product.go b/gomall/app/product/biz/model/product.go index c1a23362..f8d1c352 100644 --- a/gomall/app/product/biz/model/product.go +++ b/gomall/app/product/biz/model/product.go @@ -76,7 +76,6 @@ func (c CachedProductQuery) GetById(productId int) (product Product, err error) } return nil }() - if err != nil { product, err = c.productQuery.GetById(productId) if err != nil {