Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test lint 2 #87

Closed
wants to merge 2 commits into from
Closed

Test lint 2 #87

wants to merge 2 commits into from

Conversation

goruha
Copy link
Member

@goruha goruha commented May 3, 2024

what

  • Test lint 2

@goruha goruha requested review from a team as code owners May 3, 2024 19:19
@goruha goruha requested review from kevcube and joe-niland May 3, 2024 19:19
@goruha goruha requested a review from a team as a code owner May 3, 2024 19:20
@mergify mergify bot added triage Needs triage needs-cloudposse Needs Cloud Posse assistance labels May 3, 2024
Copy link

mergify bot commented May 3, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@@ -6,13 +6,13 @@ locals {

module "bucket_name" {
source = "cloudposse/label/null"
version = "0.25.0"
version = "0.25.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[terraform fmt -recursive] reported by reviewdog 🐶

Suggested change
version = "0.25.0"
version = "0.25.0"


enabled = local.generate_bucket_name

id_length_limit = 63 # https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html

context = module.this.context
context = module.this.context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[terraform fmt -recursive] reported by reviewdog 🐶

Suggested change
context = module.this.context
context = module.this.context

@goruha goruha closed this May 3, 2024
@goruha goruha deleted the test-lint-2 branch May 3, 2024 19:22
@mergify mergify bot removed needs-cloudposse Needs Cloud Posse assistance triage Needs triage labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant