Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ɵmarkDirty for new angular version #272

Closed
ambeur opened this issue Aug 18, 2022 · 6 comments · Fixed by #276
Closed

Replace ɵmarkDirty for new angular version #272

ambeur opened this issue Aug 18, 2022 · 6 comments · Fixed by #276
Labels
type: bug/fix This is a bug or at least needs a fix

Comments

@ambeur
Copy link
Contributor

ambeur commented Aug 18, 2022

ɵmarkDirty was removed from the @angular/core in 14.2.0 so it should be replaced with some alternative solution.

Currently in @angular/[email protected] I face the error ./node_modules/ngx-sub-form/fesm2020/ngx-sub-form.mjs:877:6-16 - Error: export 'ɵmarkDirty' (imported as 'ɵmarkDirty') was not found in '@angular/core'

There is some ideas what to use instead rx-angular/rx-angular#1386

@maxime1992
Copy link
Contributor

Ah, we knew this day might come 😬. Let see how the issue in RX gets fixed and we'll probably apply the same.

Thanks for reporting the issue and finding a similar one 👍

@maxime1992 maxime1992 added the type: bug/fix This is a bug or at least needs a fix label Aug 22, 2022
@anschm
Copy link
Contributor

anschm commented Sep 8, 2022

Have the same issues. Any idea when this gets fixed?

@svenank3r
Copy link

@maxime1992 Sorry to repeat the question, but do you have any idea when this issue will be resolved?

It seems like rx-angular found a fix for this issue, not sure if you can also use that fix :)?
Here you also mentioned we might not need markDirty anymore?

@maxime1992
Copy link
Contributor

Hello. I do not have the time to investigate this. If anyone is willing to take a look, I'm assuming this wouldn't be too much of a change and I could review that's it

@maxime1992
Copy link
Contributor

maxime1992 commented Sep 26, 2022

Hey guys, this is now fixed thanks to @Waterstraal 👏.

The release should be available in a few minutes :)

EDIT: welp... This is without counting on the unit tests failure... will need more investigation sorry

@maxime1992
Copy link
Contributor

This just got fixed/deployed in 6.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug/fix This is a bug or at least needs a fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants