Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new module to help customers invalidate derived versions of transformations #76

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Add new module to help customers invalidate derived versions of transformations #76

merged 7 commits into from
Sep 19, 2023

Conversation

tommyg-cld
Copy link
Contributor

@tommyg-cld tommyg-cld commented Aug 1, 2023 •
edited
Loading

Brief Summary of Changes

What does this PR address?

  • GitHub issue (Add reference - #XX)
  • Refactoring
  • New feature
  • Bug fix
  • Adds more tests

Are tests included?

  • Yes
  • No

Reviewer, please note:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

const-cloudinary
const-cloudinary requested changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@const-cloudinary const-cloudinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!
Please see my review

cloudinary_cli/utils/api_utils.py Outdated Show resolved Hide resolved
cloudinary_cli/utils/api_utils.py Outdated Show resolved Hide resolved
cloudinary_cli/utils/api_utils.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
carlevison
carlevison reviewed Sep 18, 2023
View reviewed changes
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
cloudinary_cli/modules/regen_derived.py Outdated Show resolved Hide resolved
@const-cloudinary const-cloudinary merged commit 6ab54e3 into master Sep 19, 2023
10 checks passed
@const-cloudinary const-cloudinary deleted the feature/add-new-delete-all-derived-by-transformation-module branch September 19, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlevison carlevison carlevison approved these changes

@const-cloudinary const-cloudinary Awaiting requested review from const-cloudinary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommyg-cld @const-cloudinary @carlevison