-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive video gets cut off when using full screen API on parent element #64
Comments
I'm trying to see what I can do with the
|
You can disable the Lemme know if this resolves the issue you're running into! |
Thanks @third774 Just started experimenting with that... Will post an update once I get it. Is it expected for the |
Got the fix for the aspect ratio. Only missing part is vertical centering.
|
Also, would it be feasible to get a |
The Which element did you have in mind that the |
I have a situation where I have the player wrapped in a parent div that the user can toggle full screen on, as in, not by using the fullscreen button in the player itself. This is so that other elements can be included in fullscreen mode. The lib I'm using for this is https://www.npmjs.com/package/react-full-screen.
The problem is that the aspect ratio doesn't get updated correctly which results in the video getting cut off on large screens.
It looks to be because of the
padding-top
on the iframe wrapper div.The text was updated successfully, but these errors were encountered: