Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide type annotations #76

Open
Gobot1234 opened this issue Jul 29, 2023 · 5 comments · May be fixed by #89
Open

Provide type annotations #76

Gobot1234 opened this issue Jul 29, 2023 · 5 comments · May be fixed by #89
Assignees
Labels
enhancement New feature or request

Comments

@Gobot1234
Copy link

Gobot1234 commented Jul 29, 2023

Would you be open adding type annotations (in the form of .pyi files) to this project? I have them pretty much ready to go if you want

@buffer buffer self-assigned this Aug 3, 2023
@buffer buffer added the enhancement New feature or request label Aug 3, 2023
@buffer
Copy link
Collaborator

buffer commented Aug 3, 2023

First of all sorry for the late reply. I am totally open to that so please feel free to share/open a PR. Thanks!

@Gobot1234
Copy link
Author

This might have to wait till I can compile a mac arm version on my machine cause I don't particularly fancy tangling with c++ right now.

@buffer
Copy link
Collaborator

buffer commented Aug 3, 2023

No rush at all. Thanks for taking care of it. Really appreciate

@devm18426
Copy link
Contributor

Hi @buffer, me again.

I'd be interested in picking this up since it doesn't seem like too much work.
There's one small thing to consult with you about. Type hints have improved gradually over the lifespan of Python 3. Initially supported exclusively through the typing package, then becoming slightly more native in 3.7 with the annotations future feature and finally reaching their current and most native state in 3.9 with the full inclusion of the annotations feature.
Looking at setup.py it seems that this package supports a minimum Python version of 3.6, which means none of the newer type hint features. It would be nice to fully take advantage of the annotations feature with 3.9 however 3.7 could also do.
I propose raising the minimum supported Python version to at least 3.9 for this reason and 2 more:

  • 3.6 and 3.7 are already at end-of-life (source].
  • Using pip installation statistics this guy is able to approximate the popularity/adoption of Python versions. As of now it would appear that 3.7 has overtaken 3.6 by far and 3.8 seems to be tied with 3.7, with 3.9 not that far behind.

I'd love to hear your thoughts on the matter.

@buffer
Copy link
Collaborator

buffer commented Oct 3, 2023

Hey @devm18426,
glad you want to step in! Totally agree with you. There is no reason nowadays to still support Python versions 3.6, 3.7 and 3.8 so I am going to drop them soon. I will take care of updating the setup file and the workflows in the next hours.

Thanks!

UPDATE: Just dropped Python versions 3.6, 3.7 and 3.8 support

@devm18426 devm18426 linked a pull request Oct 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants