Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed with nginx 1.12.2 #86

Open
kevin25 opened this issue Nov 8, 2017 · 4 comments
Open

Failed with nginx 1.12.2 #86

kevin25 opened this issue Nov 8, 2017 · 4 comments

Comments

@kevin25
Copy link

kevin25 commented Nov 8, 2017

root@server:/usr/local/src/nginx-1.12.2# patch -p1 < nginx_http2_hpack.patch
patching file auto/modules
patching file auto/options
patching file src/core/ngx_murmurhash.c
patching file src/core/ngx_murmurhash.h
patching file src/http/v2/ngx_http_v2.c
Hunk #2 succeeded at 2036 (offset 16 lines).
patching file src/http/v2/ngx_http_v2.h
Hunk #5 succeeded at 393 (offset -8 lines).
patching file src/http/v2/ngx_http_v2_filter_module.c
Hunk #2 succeeded at 46 with fuzz 2 (offset -2 lines).
Hunk #3 succeeded at 129 (offset -4 lines).
Hunk #4 succeeded at 138 (offset -4 lines).
Hunk #5 succeeded at 401 (offset -4 lines).
Hunk #6 succeeded at 409 (offset -4 lines).
Hunk #7 succeeded at 429 (offset -4 lines).
Hunk #8 succeeded at 476 (offset -4 lines).
Hunk #9 succeeded at 528 with fuzz 1 (offset -4 lines).
Hunk #10 FAILED at 564.
Hunk #11 FAILED at 634.
Hunk #12 FAILED at 660.
Hunk #13 succeeded at 583 (offset -116 lines).
3 out of 13 hunks FAILED -- saving rejects to file src/http/v2/ngx_http_v2_filter_module.c.rej
patching file src/http/v2/ngx_http_v2_table.c

Failed with nginx 1.12.2. Can anyone update it?

@injust
Copy link
Contributor

injust commented Nov 8, 2017

@kevin25 Use nginx_1.13.1_http2_hpack.patch instead

@kevin25
Copy link
Author

kevin25 commented Nov 8, 2017

Thank you. Are you sure it works the same?

@injust
Copy link
Contributor

injust commented Nov 8, 2017

You can test it yourself with h2load.

@kevin25
Copy link
Author

kevin25 commented Nov 8, 2017

Thank you so much, @injust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants