Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

span_fn should add tag error=true for functions returning Result when is_err is true #31

Open
toffaletti opened this issue Mar 5, 2024 · 1 comment

Comments

@toffaletti
Copy link

It would be nice to automatically get error tags, which jaeger and other frontends have special ui treatment for.

@evanrittenhouse
Copy link
Contributor

evanrittenhouse commented Aug 15, 2024

You can assign this to me, it'd be nice to have for some stuff we're working on. I'll have to figure out how to handle the case where an error tag is already added. For now I think it's fine to just exclude it if the tag has it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants