Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWX-18764 Wait for creation to finish for hive #167

Merged
merged 2 commits into from
Oct 31, 2024
Merged

DWX-18764 Wait for creation to finish for hive #167

merged 2 commits into from
Oct 31, 2024

Conversation

tevesz
Copy link
Contributor

@tevesz tevesz commented Oct 25, 2024

In this change the hive virtual warehouse creation and deletion is awaited. Moved the module to virtual warehouse package, to align with the new package structure.

The hive virtual warehouse creation and deletion is awaited.
@tevesz tevesz requested a review from a team as a code owner October 25, 2024 21:43
Copy link

github-actions bot commented Oct 25, 2024

Go test coverage: 33.3% for commit 9da34ec
⚠️ 2 of 14 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                                  | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest                         |    26.9%
+ github.com/cloudera/terraform-provider-cdp/provider                           |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub                  |    36.3%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake                 |     8.4%
- github.com/cloudera/terraform-provider-cdp/resources/de                       |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws           |    72.4%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/databasecatalog       |    66.7%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/virtualwarehouse/hive |    69.6%
+ github.com/cloudera/terraform-provider-cdp/resources/environments             |    44.3%
+ github.com/cloudera/terraform-provider-cdp/resources/iam                      |     2.8%
- github.com/cloudera/terraform-provider-cdp/resources/ml                       |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb                     |    25.3%
+ github.com/cloudera/terraform-provider-cdp/utils                              |    51.3%
+ github.com/cloudera/terraform-provider-cdp/utils/test                         |    68.8%

Copy link
Contributor

@gregito gregito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please generate the docs and provide example(s) for this resource. otherwise lgtm

@gregito
Copy link
Contributor

gregito commented Oct 31, 2024

please add the example too

@tevesz
Copy link
Contributor Author

tevesz commented Oct 31, 2024

please add the example too

There is an exmaple available: https://github.com/cloudera/terraform-provider-cdp/blob/main/examples/resources/cdp_dw_hive/resource.tf I haven't added any new non computed field yet, that will be the next PR

@gregito gregito requested review from gregito and vcsomor October 31, 2024 15:51
@gregito gregito merged commit ed86938 into main Oct 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants