Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain all cookies by default #509

Open
joemcdonnell opened this issue Apr 24, 2023 · 1 comment
Open

Retain all cookies by default #509

joemcdonnell opened this issue Apr 24, 2023 · 1 comment

Comments

@joemcdonnell
Copy link
Collaborator

connect's 'http_cookie_names' parameter specifies a list of cookies to retain and pass along for HS2 HTTP connections. This currently defaults to ['impala.auth', 'impala.session.id', 'hive.server2.auth'] (see https://github.com/cloudera/impyla/blob/master/impala/dbapi.py#L192 ).

In general, we don't know what proxies are between impala-shell and Impala, and we don't know what cookie name they rely on being preserved. As an example, Apache Knox can rely on a cookie it sets to route requests to the appropriate Impala coordinator. Limiting our cookie preservation to a small allow list makes this much more brittle and hard to use. Clients need to know the right list of cookies to put in http_cookie_names, and that is not obvious.

It seems like the default behavior should be to preserve all cookies. Maybe http_cookie_names=None adopts this behavior, and the user can still specify http_cookie_names to limit the cookies for unusual cases.

Companion Impala issue: IMPALA-12093
@MikaelSmith
Copy link
Contributor

I'm interested in doing this, can you assign it to me?

MikaelSmith added a commit to MikaelSmith/impyla that referenced this issue Jun 28, 2024
@MikaelSmith
Support wildcard http_cookie_names (cloudera#509)
f63066c 
Adds wildcard ('*') support to the `http_cookie_names` connect property
to preserve all cookies returned by the server. Preserves prior behavior
for any other value of `http_cookie_names`.
MikaelSmith added a commit to MikaelSmith/impyla that referenced this issue Jun 28, 2024
@MikaelSmith
Support wildcard http_cookie_names (cloudera#509)
2861464 
Adds wildcard ('*') support to the `http_cookie_names` connect property
to preserve all cookies returned by the server. Preserves prior behavior
for any other value of `http_cookie_names`.
MikaelSmith added a commit to MikaelSmith/impyla that referenced this issue Jun 28, 2024
@MikaelSmith
Support wildcard http_cookie_names (cloudera#509)
ac26cf3 
Adds wildcard ('*') support to the `http_cookie_names` connect property
to preserve all cookies returned by the server. Preserves prior behavior
for any other value of `http_cookie_names`.
MikaelSmith added a commit to MikaelSmith/impyla that referenced this issue Aug 6, 2024
@MikaelSmith
Support wildcard http_cookie_names (cloudera#509)
eccd976 
Adds wildcard ('*') support to the `http_cookie_names` connect property
to preserve all cookies returned by the server. Preserves prior behavior
for any other value of `http_cookie_names`.
csringhofer pushed a commit that referenced this issue Aug 7, 2024
@MikaelSmith
Support wildcard http_cookie_names (#509) (#542)
9a853c1 
Adds wildcard ('*') support to the `http_cookie_names` connect property
to preserve all cookies returned by the server. Preserves prior behavior
for any other value of `http_cookie_names`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikaelSmith @joemcdonnell