Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #26

Closed
wants to merge 8 commits into from
Closed

Minor fixes #26

wants to merge 8 commits into from

Conversation

ylysn
Copy link

@ylysn ylysn commented Jan 30, 2024

Multiple fixes to support stacks of 7.1.9 with ECS 1.5.2 and CEM 2.x
Fixes #25
Fixes #27
Fixes #28
Fixes #29
Fixes #30

@ylysn ylysn changed the title Add ECS instances Minor fixes Jan 30, 2024
@ylysn ylysn marked this pull request as draft January 30, 2024 19:00
@ylysn ylysn closed this Jan 30, 2024
@ylysn ylysn reopened this Jan 30, 2024
Copy link
Collaborator

@asdaraujo asdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ylysn Please check the comments below. Let me know if you have any questions.

setup/terraform/manage-instances.sh Show resolved Hide resolved
@@ -1329,6 +1329,8 @@ function deploy_cluster_prereqs() {
yum_install nodejs gcc-c++ make shellinabox mosquitto transmission-cli rh-python38 rh-python38-python-devel httpd
# Below is needed for secure clusters (required by Impyla)
yum_install cyrus-sasl-md5 cyrus-sasl-plain cyrus-sasl-gssapi cyrus-sasl-devel
# SSB-LB-UI needs libssl.so.1.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ylysn Do you know a way to reproduce the error that led you to add this?
I'm curious what may have caused this, since I never hit this problem.
Which stack(s) were you testing?

@@ -35,6 +35,17 @@ if [[ $ACTION == "install-prereqs" ]]; then
fi

deploy_os_prereqs
# Install dependencies on python38 for ECS 1.5.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same set of steps used to install Python 3.8 on the cluster node, right?
Could you make this into a "install_python" function in common.sh and use that same function on both setup.sh and setup-ecs.sh?

It's going to be cleaner and easier to maintain.

@@ -222,6 +222,13 @@ EOF
chkconfig --add efm
chown -R root:root /opt/cloudera/cem/${EFM_BASE_NAME}
sed -i.bak 's#APP_EXT_LIB_DIR=.*#APP_EXT_LIB_DIR=/usr/share/java#' /opt/cloudera/cem/efm/conf/efm.conf
if [[ $CEM_MAJOR_VERSION == 2 ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the latest changes that I made to the edge2ai deployment, I added support for the installation of any OpenJDK releases available in the public archive. All you need now is to replace the "JAVA_PACKAGE_NAME" variable in the stack with "OPENJDK_VERSION" (e.g. OPENJDK_VERSION=17.0.2).

With this, this section here is no longer necessary.
The latest 7.1.9 published also contain the latest CEM and CEM agents versions.

@asdaraujo
Copy link
Collaborator

Hi @ylysn , I saw that you pushed an update, but not sure if it's ready for another review yet.
Once it is, please ping me here.
Thanks!

@ylysn ylysn closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants