Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow multistage Dockerfiles by removing AS <stage name> in validation #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow multistage Dockerfiles by removing AS <stage name> in validation #112

wants to merge 1 commit into from

Conversation

Sainomori
Copy link
Contributor

@Sainomori Sainomori commented May 28, 2024 •
edited
Loading

fixes #103

  • Modified the validate_docker_compose_yml function to support multistage Dockerfiles.
  • Updated the FROM line parsing to remove the AS part for case-insensitive comparison.
  • This ensures compatibility with Dockerfiles using multistage builds.

@Sainomori Sainomori force-pushed the issue-103-allow-multistage branch from 6388f0b to f94e9a0 Compare May 28, 2024 15:04
@Sainomori
fix: allow multistage Dockerfiles by removing AS <stage name> in vali…
73cff33 
…dation

- Modified the validate_docker_compose_yml function to support multistage Dockerfiles.
- Updated the FROM line parsing to remove the AS <stage name> part for case-insensitive comparison.
- This ensures compatibility with Dockerfiles using multistage builds.
@Sainomori Sainomori force-pushed the issue-103-allow-multistage branch from f94e9a0 to 73cff33 Compare May 29, 2024 08:13
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multistage Dockerfile
1 participant
@Sainomori