You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The default configuration(logger names/logging levels in each module) doesn't seem to be reasonable when using this package as a library. A simple logging.basicConfig(level=logging.INFO) could easily flood the logging output.
I know I can make it less noisy by setting the loggers used in the module individually like logging.getLogger(logger_name).setLevel(some_other_level), but the logger names in this module are not really consistent such as prefixing with a single module name or so, I can only go to the source code to find out all the logger names used rather than adding a prefix filter to disable all loggers in one go:
for _logger_name in ("Evaluator", "evaluation", "NameContainer", "celtypes", "Environment"):
logging.getLogger(_logger_name).setLevel(logging.WARNING)
This approach doesn't really look sustainable, especially, I can't know if there will be any change, such as new loggers added; old loggers removed, etc., in this module.
Therefore, I'm wondering if it's possible to support one of the followings going forward?
Consolidate the logger names into something predictable
Add an option to adjust all the loggers used
Allow users to pass in loggers
others idk
Thank you!
The text was updated successfully, but these errors were encountered:
Hi, it would also be nicer to fix the default logging. I'm coming from https://github.com/bufbuild/protovalidate and can see logs 1000s of logs on validating a single proto message. I think these should be debug logs and not info logs. Not sure if this can be done in protovalidate in which case, I can raise a request there.
The default configuration(logger names/logging levels in each module) doesn't seem to be reasonable when using this package as a library. A simple
logging.basicConfig(level=logging.INFO)
could easily flood the logging output.I know I can make it less noisy by setting the loggers used in the module individually like
logging.getLogger(logger_name).setLevel(some_other_level)
, but the logger names in this module are not really consistent such as prefixing with a single module name or so, I can only go to the source code to find out all the logger names used rather than adding a prefix filter to disable all loggers in one go:This approach doesn't really look sustainable, especially, I can't know if there will be any change, such as new loggers added; old loggers removed, etc., in this module.
Therefore, I'm wondering if it's possible to support one of the followings going forward?
Thank you!
The text was updated successfully, but these errors were encountered: