Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'MessageType' support #43

Open
Alfus opened this issue Jun 8, 2023 · 2 comments
Open

'MessageType' support #43

Alfus opened this issue Jun 8, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Alfus
Copy link

Alfus commented Jun 8, 2023

I am in the process of implementing protovalidate in pure-python using cel-python have push things as far as I can from the outside leaving me the following 7 issues:

image

1-2, 5-7: cel-python doesn't support nano resolution
3: cel-python doesn't support protobuf messages
4: cel-python doesn't check the data is valid before applying the regex

I am mostly interested (3). I have implemented most of the logic needed to seamlessly integrate protobuf into cel-python, by materializing protobuf messages as a map; however, as protobuf supports cycles in the type system, this is insufficient (as well as inefficient). I am curious if there is any interest to add support, potentially based on the code I have already written.

@kapilt
Copy link
Collaborator

kapilt commented Jul 22, 2023

pull requests welcome, ideally the protobuf integration is limited to when using protobuf.

@slott56 slott56 added enhancement New feature or request help wanted Extra attention is needed labels May 21, 2024
@slott56
Copy link
Collaborator

slott56 commented May 21, 2024

"based on the code I have already written" Intriguing. Please share more. A pull request would be a very helpful way to clarify your intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants