From a235cd3ea1e077cc990280c0a12de3e0d72d1113 Mon Sep 17 00:00:00 2001
From: Devdatta Kulkarni <devdattakulkarni@gmail.com>
Date: Wed, 8 Mar 2023 12:24:40 +0000
Subject: [PATCH] Ensuring that KubePlus Pod comes up without error after a
 restart

We check to see if KubePlus's mutatingwebhookconfiguration object
is present in the cluster before trying to register one.

Fixes: https://github.com/cloud-ark/kubeplus/issues/1122
---
 deploy/kubeconfiggenerator.py                | 40 ++++++++++----------
 deploy/webhook-create-self-signed-ca-cert.sh |  7 ++++
 2 files changed, 27 insertions(+), 20 deletions(-)

diff --git a/deploy/kubeconfiggenerator.py b/deploy/kubeconfiggenerator.py
index acfebb35..00995c0d 100644
--- a/deploy/kubeconfiggenerator.py
+++ b/deploy/kubeconfiggenerator.py
@@ -79,16 +79,19 @@ def run_command(self, cmd):
                 #print("Inside run_command")
                 print(cmd)
                 cmdOut = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True).communicate()
-                out = cmdOut[0]
-                err = cmdOut[1]
+                out = cmdOut[0].decode('utf-8')
+                err = cmdOut[1].decode('utf-8')
                 print(out)
-                if out != '':
-                        return out
-                        #printlines(out.decode('utf-8'))
+                print("---")
+                print(err)
+                return out, err
+                #if out != '':
+                #        return out
+                #        #printlines(out.decode('utf-8'))
                 #print("Error:")
                 #print(err)
-                if err != '':
-                        return err
+                #if err != '':
+                #        return err
                         #printlines(err.decode('utf-8'))
 
         def _create_kubecfg_file(self, sa, namespace, token, ca, server):
@@ -147,8 +150,7 @@ def _create_kubecfg_file(self, sa, namespace, token, ca, server):
                         cmd = "kubectl create configmap " + configmapName + " -n " + namespace + " --from-file=" + os.getenv("HOME") + "/" + fileName
                         self.run_command(cmd)
                         get_cmd = "kubectl get configmap " + configmapName + " -n "  + namespace
-                        output = self.run_command(get_cmd)
-                        output = output.decode('utf-8')    
+                        output, error = self.run_command(get_cmd)
                         if 'Error from server (NotFound)' in output:
                                 time.sleep(2)
                                 print("Trying again..")
@@ -398,16 +400,13 @@ def _create_secret(self, sa, namespace):
                 print("---")
                 created = False
                 while not created:
-                        cmd = " kubectl create -f " + filePath
-                        out = self.run_command(cmd)
-                        if out != '':
-                                out = out.decode('utf-8').strip()
-                                print(out)
-                                if 'created' in out:
-                                        created = True
-                        else:
-                                time.sleep(2)
-                print("Create secret:" + out)
+                    cmd = " kubectl create -f " + filePath
+                    out, err = self.run_command(cmd)
+                    if 'created' in out or 'AlreadyExists' in err:
+                        created = True
+                    else:
+                        time.sleep(2)
+                #print("Create secret:" + out)
                 return out
 
         def _generate_kubeconfig(self, sa, namespace):
@@ -423,7 +422,8 @@ def _generate_kubeconfig(self, sa, namespace):
                 secretName = sa
                 out = self._create_secret(secretName, namespace)
                 print("Create secret:" + out)
-                if 'secret/' + sa + ' created' in out:
+                #if 'secret/' + sa + ' created' in out:
+                if True: # do this always
                         #json_output = json.loads(out)
                         #secretName = json_output["secrets"][0]["name"]
                         #print("Secret Name:" + secretName)
diff --git a/deploy/webhook-create-self-signed-ca-cert.sh b/deploy/webhook-create-self-signed-ca-cert.sh
index 17a42948..d5ba09ca 100755
--- a/deploy/webhook-create-self-signed-ca-cert.sh
+++ b/deploy/webhook-create-self-signed-ca-cert.sh
@@ -57,6 +57,13 @@ echo $secret
 echo $service
 csrName=${service}.${namespace}
 
+# Check if mutatingwebhookconfiguration object is present; if so, we can assume that the webhook has been installed;
+op=$(kubectl get mutatingwebhookconfigurations platform-as-code.crd-binding 2>&1 || true) 
+if [[ $op == *"AGE"* ]]; then
+   echo "Mutating webhook is already configured."
+   exit
+fi
+
 # Source: https://www.funkypenguin.co.nz/blog/self-signed-certificate-on-mutating-webhook-requires-double-encryption/
 # 1. Create CA key and CA cert
 openssl genrsa -out rootCA.key 4096