Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique tasks should be unique per queue #87

Open
thomasst opened this issue Oct 5, 2017 · 0 comments
Open

Unique tasks should be unique per queue #87

thomasst opened this issue Oct 5, 2017 · 0 comments

Comments

@thomasst
Copy link
Member

thomasst commented Oct 5, 2017

When removing a unique task from a queue, we check other states (e.g. scheduled / error / etc.) before removing the task object from Redis to make sure the task is not referenced anywhere else. However, we don't check queues with other names, we just check the current queue. I propose to include the queue name in the task ID hash to prevent issues with removing unique tasks. Alternatively, we'd have to check all other queues for tasks before removing a unique task, or have some kind of reference counter.

This is potentially a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant