Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a way to manage sizes for pictures #36

Open
ryuran opened this issue Sep 3, 2018 · 1 comment
Open

Find a way to manage sizes for pictures #36

ryuran opened this issue Sep 3, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@ryuran
Copy link
Contributor

ryuran commented Sep 3, 2018

Currently the documentation say to run a commande for each sources.
We could make the script return a sizes list to each sources of a picture element with media query detected when runing resize by puppeteer.
@ryuran ryuran added the enhancement New feature or request label Sep 3, 2018
@nhoizey
Copy link
Member

nhoizey commented Sep 3, 2018

I guess the best would be to find if the <img> parent node is a <picture> and then look at its <source>s and their media attributes.

Really not easy, but there might be some Node lib helping.

@nhoizey nhoizey added this to the Later milestone Sep 3, 2018
@ryuran ryuran changed the title Find a way to manage size for pictures Find a way to manage sizes for pictures Sep 5, 2018
@nhoizey nhoizey removed this from the Later milestone Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhoizey @ryuran